Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "ignore_missing" option to concerned processors #2001

Merged
merged 4 commits into from
Oct 21, 2021

Conversation

deguif
Copy link
Collaborator

@deguif deguif commented Oct 21, 2021

No description provided.

@deguif deguif force-pushed the processor-ignore-missing-trait branch from 59b6f5e to da404bd Compare October 21, 2021 13:12
@thePanz
Copy link
Collaborator

thePanz commented Oct 21, 2021

We should rebase this PR: the changelog is not in sync with the latest master branch

@deguif deguif force-pushed the processor-ignore-missing-trait branch from da404bd to 1d3fb91 Compare October 21, 2021 13:46
@deguif deguif force-pushed the processor-ignore-missing-trait branch from 1d3fb91 to 28ff6cc Compare October 21, 2021 13:47
@deguif
Copy link
Collaborator Author

deguif commented Oct 21, 2021

@thePanz Done.
I also added some unit tests on impacted processors.

@deguif deguif self-assigned this Oct 21, 2021
@thePanz thePanz self-requested a review October 21, 2021 13:53
@deguif deguif merged commit 702427b into ruflin:master Oct 21, 2021
@deguif deguif deleted the processor-ignore-missing-trait branch October 21, 2021 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants